Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 16 bit output #222

Merged
merged 18 commits into from
Aug 15, 2024
Merged

Enable 16 bit output #222

merged 18 commits into from
Aug 15, 2024

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Aug 14, 2024 •
edited
Loading

closes #162

  • add code
  • test added code

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

File Coverage Missing
All files 88% ✅
src/pytom_tm/correlation.py 85% ❌ 98-99 131
src/pytom_tm/entry_points.py 79% ❌ 28 113-130 235-280 385-404 540-558 1038-1049
src/pytom_tm/extract.py 76% ❌ 127-138 205-212 256-261 354-372
src/pytom_tm/io.py 81% ❌ 20 40 58 76 89 110-116 133-137 144 150 162 169 216-218 288 434-442 467
src/pytom_tm/mask.py 80% ❌ 76 94 104-105
src/pytom_tm/parallel.py 89% ✅ 14-15 93 104-105 111 176
src/pytom_tm/plotting.py 16% ❌ 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-397
src/pytom_tm/tmjob.py 97% ✅ 372-373 389 399-404 483 611 660
src/pytom_tm/utils.py 78% ❌ 18-20
src/pytom_tm/weights.py 96% ✅ 59 314-318 325 535 540 545

Minimum allowed coverage is 86%

Generated by 🐒 cobertura-action against 288b934

@sroet sroet marked this pull request as ready for review August 14, 2024 16:23
@sroet sroet requested review from FridoF and McHaillet August 14, 2024 16:24
McHaillet
McHaillet reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look and before I review in detail, I was wondering if saving the angle index volume in float16 works for a large rotation search space. The angular search can be on the order of a million values and the integer precision needs to be high enough to store those indices. Does that still work with float16?

@sroet
Copy link
Collaborator Author

sroet commented Aug 14, 2024

I had a quick look and before I review in detail, I was wondering if saving the angle index volume in float16 works for a large rotation search space. The angular search can be on the order of a million values and the integer precision needs to be high enough to store those indices. Does that still work with float16?

Yeah, you're right. Max is ~65000. Will change that back tomorrow

@sroet
Copy link
Collaborator Author

sroet commented Aug 15, 2024

@McHaillet thanks for catching that, changed it back. Please have another look

McHaillet
McHaillet approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also nice that you added a test for writing an integer volume to MRC.

@sroet sroet merged commit 171f4de into SBC-Utrecht:main Aug 15, 2024
2 checks passed
@sroet sroet deleted the enable_16_bit_mode branch August 15, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McHaillet McHaillet McHaillet approved these changes

@FridoF FridoF Awaiting requested review from FridoF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

save score volume as float16
2 participants
@sroet @McHaillet